Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reordering example sentences #1359

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Allow reordering example sentences #1359

merged 5 commits into from
Jan 13, 2025

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Jan 10, 2025 •
edited by hahn-kev
Loading

One more part of #1246

Generalized the exclusion of the Order property from generated TS by checking for the MiniLcmInternal Attribute.

fixes #1363

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit af5d72f. ± Comparison against base commit 7595e0b.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the feat/1246-allow-reordering-example-sentences branch from 03e2271 to 3c62972 Compare January 10, 2025 09:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

C# Unit Tests

103 tests  ±0   103 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit af5d72f. ± Comparison against base commit 7595e0b.

♻️ This comment has been updated with latest results.

@myieye myieye requested a review from hahn-kev January 10, 2025 10:28
@myieye myieye marked this pull request as ready for review January 10, 2025 10:28
@myieye myieye mentioned this pull request Jan 10, 2025
Open
4 tasks
hahn-kev
hahn-kev requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, there's a strange issue in one of the tests and some nitpicks as well.

backend/FwLite/MiniLcm.Tests/UpdateEntryTestsBase.cs Outdated Show resolved Hide resolved
backend/FwLite/MiniLcm.Tests/UpdateEntryTestsBase.cs Outdated Show resolved Hide resolved
backend/FwLite/MiniLcm/IMiniLcmWriteApi.cs Show resolved Hide resolved
frontend/viewer/src/lib/entry-editor/NewEntryDialog.svelte Show resolved Hide resolved
@hahn-kev hahn-kev mentioned this pull request Jan 13, 2025
Closed
@myieye myieye merged commit a8d082f into develop Jan 13, 2025
24 checks passed
@myieye myieye deleted the feat/1246-allow-reordering-example-sentences branch January 13, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahn-kev hahn-kev hahn-kev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FwLiteWeb creating new sense has entryId "" (empty string), which .NET refuses to parse as a GUID
2 participants
@myieye @hahn-kev